-
-
Notifications
You must be signed in to change notification settings - Fork 422
feat: detect generic config filenames #4102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect generic config filenames #4102
Conversation
|
📊 Quantitative test results for language: |
|
Yes, removing duplicates makes sense. |
|
Done, I got a few more ideas after removing duplicates so I've made some improvements. |
|
Do we really want to block phpinfo.php at PL1? Rest is very cool. |
|
@dune73 I think it's fine since it's only targeting In the case of |
|
I was not aware of CVE-2023-49103. It's still a tough call for me (since it's used as a PoC of successful installation by so many people), but this CVE tilts it in favor of blocking for me. |
|
What is needed here? Do we merge? |
|
@fzipi I'm just waiting for someone to review and approve. Everything else is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's see how this goes. I think if people really wants to show the phpinfo, they can do it in their own file with their naming. They don't need to call the file phpinfo.php. So it will be an explicit disclosure, not an ocassional, unintended one.
This PR adds generic entries to
restricted-files.dataand friends to detect most config filenames and permutations of them.Since I've added a large list of generic filenames, should I remove or comment out the duplicate entries? there are a fair few entries that are redundant because of this change.