Skip to content

Conversation

@Xhoenix
Copy link
Member

@Xhoenix Xhoenix commented Apr 9, 2025

No description provided.

@Xhoenix Xhoenix added the release:new-detection In this PR we introduce a new detection label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@Xhoenix Xhoenix requested a review from fzipi April 9, 2025 06:42
@Xhoenix Xhoenix changed the title feat: added ASP.NET errors feat: added detection for ASP.NET errors Apr 9, 2025
@Xhoenix Xhoenix requested a review from theseion April 9, 2025 10:07
@S0obi
Copy link
Contributor

S0obi commented Apr 11, 2025

Thanks for this PR! Should we not have a separated rule file, similar to RESPONSE-952-DATA-LEAKAGES-JAVA.conf ?

@theseion
Copy link
Contributor

Based on the decision from the monthly chat, we would probably change the put all the programming language related stuff in one place, so the Java specific one would be merged with the rest.

@Xhoenix
Copy link
Member Author

Xhoenix commented Apr 14, 2025

Based on the decision from the monthly chat, we would probably change the put all the programming language related stuff in one place, so the Java specific one would be merged with the rest.

To start with, we move all language based RESPONSE rules to RESPONSE-950-DATA-LEAKAGES.conf while tagging them with a language identifier, what do you think? The REQUEST part needs to be discussed, as it would require quite a bit of refactoring.

@fzipi
Copy link
Member

fzipi commented May 3, 2025

I think the answer then is yes, we do as you propose @Xhoenix.

Xhoenix and others added 2 commits May 4, 2025 11:05
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
@Xhoenix Xhoenix added this pull request to the merge queue Jul 5, 2025
Merged via the queue into coreruleset:main with commit 5a8cd1e Jul 5, 2025
5 of 6 checks passed
@Xhoenix Xhoenix deleted the add-asp-dotnet-errors branch July 5, 2025 17:16
@fzipi fzipi mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:new-detection In this PR we introduce a new detection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants