Skip to content

Conversation

@EsadCetiner
Copy link
Member

@EsadCetiner EsadCetiner commented Mar 23, 2025

Fixes #4041

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also update the dependent files? Search for lfi-os-files and you should find them all, then run the scripts in the headers. Finally, regenerate the rules.

@EsadCetiner
Copy link
Member Author

@theseion I found a few issues running the grep command, I assume lfi-os-files.data is the source of truth for the dot files?

I had to add some missing entries to lfi-os-files.data that were only present in restricted-files.data, I'm not sure if the exclusions were intentional but I didn't find any tests testing for their removal.

The grep command was also a little broken, it wouldn't include any dot file beginning with s, I made some changes in the regex and it works now (I don't think grep works well with negated sets and non-capturing group).

@theseion
Copy link
Contributor

The grep issues are probably due to differences in grep implementations. Thanks for fixing.

@EsadCetiner
Copy link
Member Author

@theseion Looks like the PR merged a minute ago broke the tests?

@theseion
Copy link
Contributor

@theseion Looks like the PR merged a minute ago broke the tests?

Where? All tests pass, don't they?

@EsadCetiner
Copy link
Member Author

@theseion It works now, but the Nginx container was broken

@theseion
Copy link
Contributor

Thanks. I've added a fix for that to #4050

@EsadCetiner EsadCetiner added this pull request to the merge queue Mar 26, 2025
Merged via the queue into coreruleset:main with commit 2b8117f Mar 26, 2025
6 checks passed
@EsadCetiner EsadCetiner deleted the fix-docker-fp branch March 26, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we move dot files out of lfi-os-files.data? (930120)

3 participants