Skip to content

Conversation

@EsadCetiner
Copy link
Member

Fixes a false positive with printf matching SprintForTheCause by moving it to 933160 which checks for additional PHP syntax instead of just printf.

closes #3641

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi changed the title fix: SprintForTheCause false positive by moving printf to 933160 (933150 PL-1, 933160 PL-1) fix(933150): moving printf to 933160 for additional php syntax check (933150 PL-1, 933160 PL-1) Feb 27, 2025
@fzipi
Copy link
Member

fzipi commented Jun 19, 2025

@EsadCetiner Can you fix the conflicts and can we push this one to the end?

@EsadCetiner
Copy link
Member Author

@fzipi ready for review

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for pushing this!

@fzipi fzipi added this pull request to the merge queue Jun 21, 2025
Merged via the queue into coreruleset:main with commit e91c26b Jun 21, 2025
6 checks passed
@EsadCetiner EsadCetiner deleted the fix-printf-false-positive branch June 21, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule 933150 Has False Positive for URLs

4 participants