Skip to content

fix(942550): cleanup regex #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 9, 2025
Merged

fix(942550): cleanup regex #3767

merged 23 commits into from
Sep 9, 2025

Conversation

@fzipi
Copy link
Member

@fzipi fzipi commented Jul 8, 2024 •
edited
Loading

what

  • cleanup regex to have better performance
  • try to avoid patterns like .* to prevent catastrophic BT
  • update regexes for broader functions
  • add documentation for json functions in diverse DBs
  • add test to check for embedded sql comments

@github-actions github-actions bot added the Stale label Aug 22, 2024
@github-actions github-actions bot closed this Sep 5, 2024
@fzipi fzipi reopened this Sep 5, 2024
@github-actions github-actions bot removed the Stale label Sep 6, 2024
@github-actions github-actions bot added the Stale label Oct 6, 2024
@github-actions github-actions bot closed this Oct 20, 2024
@fzipi fzipi reopened this Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi changed the title fix(942559): cleanup regex fix(942550): cleanup regex Mar 7, 2025
@github-actions github-actions bot added the Stale label Apr 7, 2025
@Xhoenix Xhoenix removed the Stale label Apr 7, 2025
@github-actions github-actions bot added the Stale label May 8, 2025
@Xhoenix Xhoenix removed the Stale label May 15, 2025
@github-actions github-actions bot added the Stale label Jun 15, 2025
@fzipi fzipi mentioned this pull request Jul 4, 2025
Closed
fzipi added 3 commits July 4, 2025 10:51
@fzipi
fix(942559): cleanup regex
b7ec7fc 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
fix: 3354
4102f37 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
fix: update regex
03164b7 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Xhoenix
Xhoenix reviewed Jul 5, 2025
View reviewed changes
fzipi and others added 2 commits July 6, 2025 20:58
@fzipi @Xhoenix
Apply suggestion from @Xhoenix
e778fe1 
Co-authored-by: Xhoenix <86168235+Xhoenix@users.noreply.github.com>
@fzipi
fix: apply regex update
a869a2e 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi marked this pull request as ready for review July 6, 2025 23:59
pre-commit-ci bot and others added 2 commits July 14, 2025 13:47
@pre-commit-ci
chore(formatting): auto fixes from pre-commit hooks
0366e05 
for more information, see https://pre-commit.ci
@fzipi
fix: move lowercase from rule to regex
9356811 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
theseion
theseion requested changes Jul 15, 2025
View reviewed changes
@fzipi @theseion
Apply suggestions from code review
7082046 
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
theseion
theseion previously approved these changes Jul 16, 2025
View reviewed changes
@theseion theseion dismissed their stale review July 16, 2025 04:49

Not done yet

fzipi and others added 2 commits July 16, 2025 09:00
@fzipi
fix: remove optional spacing
55f872e 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
Merge branch 'main' into fix/3354
6ca187e
@fzipi fzipi enabled auto-merge July 16, 2025 12:12
theseion
theseion requested changes Jul 17, 2025
View reviewed changes
@fzipi fzipi mentioned this pull request Aug 4, 2025
Closed
@github-actions github-actions bot added the Stale label Aug 17, 2025
@Xhoenix Xhoenix removed the Stale label Aug 25, 2025
Xhoenix
Xhoenix reviewed Aug 28, 2025
View reviewed changes
@fzipi @theseion
Apply suggestions from code review
036957f 
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
@fzipi fzipi mentioned this pull request Sep 1, 2025
Closed
@Xhoenix
Copy link
Member

Xhoenix commented Sep 9, 2025

@EsadCetiner Pending for approval.

@fzipi fzipi added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 21ab3ea Sep 9, 2025
7 checks passed
@fzipi fzipi deleted the fix/3354 branch September 9, 2025 07:40
@EsadCetiner EsadCetiner mentioned this pull request Sep 14, 2025
Merged
@EsadCetiner EsadCetiner mentioned this pull request Sep 28, 2025
Open
@fzipi fzipi mentioned this pull request Oct 2, 2025
Merged
@touchweb-vincent touchweb-vincent mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theseion theseion theseion approved these changes

@Xhoenix Xhoenix Xhoenix approved these changes

@EsadCetiner EsadCetiner EsadCetiner approved these changes

Assignees

No one assigned

Labels

🧙 regex-assembly release:fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fzipi @Xhoenix @theseion @EsadCetiner