container-encapsulate: Mark initramfs as exclusive component #5535
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly identifies that the initramfs should be treated as a component to ensure it's placed in its own layer. The change from path_packages to path_components is the right approach. I've added one comment with a suggestion to further improve the consistency of this change by aligning the metadata handling for initramfs with how other components are processed. This will make the code cleaner and more maintainable.
HastD
force-pushed
the
initramfs-layer
branch
from
ae439c4 to
f9343fa
Compare
The initramfs is not provided by an RPM package, but should be placed in its own exclusive layer. Therefore, it should be added to `path_components`, not `path_packages`, in the `MappingBuilder`, and should have component (not package) metadata associated to it. Signed-off-by: Daniel Hast <hast.daniel@protonmail.com>
HastD
force-pushed
the
initramfs-layer
branch
from
f9343fa to
73128f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initramfs is not provided by an RPM package, but should be placed in its own exclusive layer. Therefore, it should be added to
path_components, notpath_packages, in theMappingBuilder, and should have component (not package) metadata associated to it.(At least, that's the case if I've understood the code correctly... this is my first time contributing to
rpm-ostreeso I'm not 100% sure. I investigated this code path because I'm seeing the initramfs get placed into the "unpackaged contents" layer in images build with build-chunked-oci, rather than being placed into its own layer as expected.)