Add build+test infra mirroring bootc #5525
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new build and test infrastructure using Docker and Justfile, mirroring the setup from the bootc project. This is a significant improvement, making it easier to build and test rpm-ostree in a containerized environment. The changes are well-structured, using multi-stage Docker builds and providing clear entrypoints in the Justfile. I have one minor suggestion to fix a command in the Dockerfile.
cgwalters
force-pushed
the
revamp-buildsys
branch
from
11d84cb to
d16d675
Compare
cgwalters
force-pushed
the
revamp-buildsys
branch
2 times, most recently
from
e3f313f to
0912258
Compare
The split_whitespace_unless_quoted function was using chars().enumerate() which returns character indices, but then using those indices to slice the string which requires byte indices. This triggers the char_indices_as_byte_indices clippy lint. Fixed by using char_indices() instead, which provides byte indices directly. Also refactored the end-of-string handling to occur after the loop completes, which is clearer and handles the remaining text properly regardless of multi-byte characters. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
Update the shared bootc-ubuntu-setup GitHub Action to match the latest version from bootc-dev/bootc, incorporating several improvements: - Add libvirt input parameter: Allows workflows to optionally install virtualization stack for tests that need VM support - Improve disk cleanup: Use systemd-run for parallel background cleanup operations, freeing disk space more efficiently - Add timing instrumentation: Use /bin/time to track duration of expensive operations (apt update, apt install) - Add Rust caching: Use Swatinem/rust-cache@v2 for faster builds with intelligent cache management (only save on main, lookup-only on main to avoid incremental bugs) - Add libvirt support: Install bcvk, qemu, and related virtualization tools when libvirt input is true - Add cleanup status: Display systemd cleanup units and final disk usage for better observability These changes bring rpm-ostree's CI infrastructure more in line with bootc's battle-tested setup, enabling future enhancements like VM-based integration tests. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
Fix static library linking order in libdnf-sys build script. The C++ wrapper (libdnfcxx.a) depends on both libdnf and glib, but cargo's link order requires dependencies to come after dependents. Re-emit link directives after compiling the wrapper to ensure symbols are available. This was causing undefined reference errors for g_strndup, g_free, and hy_split_nevra when building tests. Also add workspace-level lints to Cargo.toml and minor Rust cleanups. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
revamp-buildsys
branch
3 times, most recently
from
1080811 to
b203721
Compare
|
OK I'm really tempted to drop Prow. I added it long ago because we were having reliability issues with the Jenkins, but those two have always been duplicative. That said this failure is rooted in one path building an RPM and the new path isn't. We are probably going to have to bite the bullet here and switch even the default |
|
I am OK dropping prow if that is the only difference. As long as the tests are running, having both systems running the same tests is just wasting time and compute. |
|
The conflict is basically that we've added |
cgwalters
force-pushed
the
revamp-buildsys
branch
from
b203721 to
f161fe3
Compare
This introduces a Justfile and Dockerfile to enable building rpm-ostree from source in a container, following the pattern established in the bootc project. See the `Justfile` for key entrypoints. Those are now used in a new GHA flow, which we'll try to move things over to. A key difference though vs bootc is because rpm-ostree has a lot of C++ too we use sccache which greatly speeds things up across incremental rebuilds. Just one side cleanup of this is before it was *terribly* painful and manual to hack on `test-container.sh`, and now it's easy, fast and optimized. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
revamp-buildsys
branch
from
f161fe3 to
29222a1
Compare
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I'm going to look at dropping Prow here. |
2 participants
This introduces a Justfile and Dockerfile to enable building rpm-ostree
from source in a container, following the pattern established in the
bootc project.
See the
Justfilefor key entrypoints. Those are now usedin a new GHA flow, which we'll try to move things over to.
A key difference though vs bootc is because rpm-ostree has a lot
of C++ too we use sccache which greatly speeds things up across
incremental rebuilds.
Just one side cleanup of this is before it was terribly
painful and manual to hack on
test-container.sh, and now it's easy,fast and optimized.
Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters walters@verbum.org