Release 2025.12 #5524
Release 2025.12 #5524
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the 2025.12 release by updating the version number and synchronizing build dependencies. The changes appear to be in line with the documented release process. I have one suggestion to improve the maintainability of the RPM spec file by removing a redundant build dependency. For future releases, it would be beneficial to summarize dependency changes in the pull request description.
| %global librepo_version 1.18.0 | ||
|
|
||
| BuildRequires: cmake | ||
| BuildRequires: cmake >= 3.5.0 |
There was a problem hiding this comment.
Adding a version constraint to the cmake build requirement is a good improvement. However, this makes the unversioned BuildRequires: cmake on line 86 redundant. To improve clarity and maintainability of the spec file, please consider removing the redundant requirement on line 86.
|
@jmarrero: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| BuildRequires: pkgconfig(modulemd-2.0) >= %{libmodulemd_version} | ||
| BuildRequires: pkgconfig(smartcols) | ||
| BuildRequires: gettext | ||
| BuildRequires: gpgme-devel |
There was a problem hiding this comment.
No longer required by the libdnf spec: https://github.com/rpm-software-management/libdnf/blob/8eadf440cb9b44bf5c614612fba6609f415e2d0d/libdnf.spec which was removed as part of https://github.com/rpm-software-management/libdnf/releases/tag/0.71.0 in rpm-software-management/libdnf@1649796#diff-edb909e2e539271bf064d61691f61d1092ae3f56b3b01be11e544207fc955da6
2 participants
No description provided.