ci: Use fcos stable to defer porting our tests to Fedora 43 #5523
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CI to use the stable stream of Fedora CoreOS to defer porting tests that are incompatible with Fedora 43 and the new container-by-default model in FCOS. The changes involve switching to the stable branch in coreos-assembler, updating a test to use the stable FCOS container image, and removing a now-failing post-compose check script. The changes are correct and align with the stated goal of the pull request. I have one suggestion to add a TODO to track the re-implementation of the removed checks.
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
https://github.com/coreos/rpm-ostree/blob/main/ci/prow/fcos-e2e.sh#L24 needs the branch i.e. |
With FCOS using a container by default now, this is obsolete. Signed-off-by: Colin Walters <walters@verbum.org>
We use fedora-coreos:testing-devel in our jobs and it looks like that one just rebased. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
fix-ci
branch
2 times, most recently
from
f4c8a6d to
d8904fa
Compare
About half of this is generic F43 stuff, but another big half is FCOS switching to be container based by default and SO MANY of our tests assume containers aren't the default. Signed-off-by: Colin Walters <walters@verbum.org>
2 participants
About half of this is generic F43 stuff, but another big
half is FCOS switching to be container based by default
and SO MANY of our tests assume containers aren't the default.