Skip to content

build(deps): update submodule: libdnf 998efa8 to 8eadf44 #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RoyalOughtness wants to merge 1 commit into from
Closed

build(deps): update submodule: libdnf 998efa8 to 8eadf44 #5521

RoyalOughtness wants to merge 1 commit into from
+1 −1

Conversation

@RoyalOughtness
Copy link
Contributor

@RoyalOughtness RoyalOughtness commented Oct 28, 2025

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

Hi @RoyalOughtness. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 28, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the libdnf submodule to a new commit. My primary feedback is a concern about potential integration issues. The submodule update is not accompanied by any changes to the libdnf-sys wrapper crate that consumes it. If the new version of libdnf introduces breaking API changes, this could lead to build or runtime failures. I have added a comment to highlight this risk.

@jmarrero
Copy link
Member

jmarrero commented Oct 28, 2025 •
edited
Loading

Thank you for the help! I just updated: #5498 for @travier to keep all that conversation in the merged PR.

@jmarrero jmarrero closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RoyalOughtness @jmarrero @travier