Skip to content

tests: Increase disk size for container-image test #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cgwalters merged 2 commits into from
Oct 26, 2025
Merged

tests: Increase disk size for container-image test #5518

cgwalters merged 2 commits into from
Oct 26, 2025
+16 −1

Conversation

@jmarrero
Copy link
Member

@jmarrero jmarrero commented Oct 25, 2025

The container-image test was modified on
300a8a2 to compose a build-chunked-oci image and, which can exhaust the default disk space on the test.

@jmarrero
tests: Increase disk size for container-image test
531c843 
The container-image test was modified on
coreos@300a8a2
to compose a build-chunked-oci image and, which can exhaust
the default disk space on the test.
@jmarrero jmarrero mentioned this pull request Oct 25, 2025
Merged
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 25, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses test failures in the container-image test caused by insufficient disk space. The test was recently modified to compose a build-chunked-oci image, which requires more disk space than the default. The PR author increases the minimum disk size for the test by updating its kola configuration. The change is correct, well-justified, and I have no suggestions for improvement.

@jmarrero
Copy link
Member Author

jmarrero commented Oct 25, 2025 •
edited
Loading

OK.. we are down to just one and has been here for awhile:

Input state hash: c24e111465764c783161ca75b5321c19ab9ad66b26bfebf9b4799b96f1e641f0
Will download: 442 packages (725.3?MB)
Downloading from 'fedora-coreos-pool'...done
Importing packages...done: 442
--dry-run complete, updating --touch-if-changed=/tmp/tmp.0fbQFM74hx/tmp/treecompose.changed; exiting
Generating hermeto lockfile...
Resolving packages for x86_64...
filesystem error: cannot create directories: Permission denied [/.local/state]
Traceback (most recent call last):
  File "/usr/lib/coreos-assembler/konflux-rpm-lockfile", line 316, in <module>
    args.func(args)
    ~~~~~~~~~^^^^^^
  File "/usr/lib/coreos-assembler/konflux-rpm-lockfile", line 203, in generate_main
    pkg_urls = query_packages_location(locks, repoquery_args + arch_args)
  File "/usr/lib/coreos-assembler/konflux-rpm-lockfile", line 112, in query_packages_location
    result = subprocess.check_output(cmd, text=True)
  File "/usr/lib64/python3.13/subprocess.py", line 472, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
               **kwargs).stdout
               ^^^^^^^^^
  File "/usr/lib64/python3.13/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)

Well maybe a chmod 777 against /.local/state before the cosa fetch might force this? I am not sure why this is happening.... so let's debug a bit in fcos-e2e.sh

@jmarrero jmarrero force-pushed the ci-fix2 branch 3 times, most recently from 0a9ac08 to 29d9998 Compare October 25, 2025 18:46
@jmarrero
ci: Fix FCOS e2e test XDG directories and QEMU image build
78dcdcc 
Set up XDG_STATE_HOME, XDG_CACHE_HOME, and XDG_CONFIG_HOME with
proper permissions to ensure cosa operations have write access.
Also add explicit cosa buildextend-qemu step since COSA no longer
creates QEMU images by default.

Assisted-By: ChatGPT-5
@jmarrero
Copy link
Member Author

jmarrero commented Oct 26, 2025

We got green, I think this just needs a stamp.

cgwalters
cgwalters approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for tracing this down!

ci/prow/fcos-e2e.sh
# Let's force XDG vars to make sure we got permissions
# when writing to the directories
# https://specifications.freedesktop.org/basedir-spec/latest/
mkdir -p "$PWD/.state" "$PWD/.cache" "$PWD/.config"
Copy link
Member

@cgwalters cgwalters Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offhand I suspect the real problem is something in Prow is setting HOME=/

@cgwalters cgwalters merged commit d92a54a into coreos:main Oct 26, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmarrero @cgwalters