Skip to content

Conversation

@miabbott
Copy link
Member

Some whitespace cleanups too

Closes: #5514

Signed-off-by: Micah Abbott <miabbott@redhat.com>
Closes: coreos#5514

Signed-off-by: Micah Abbott <miabbott@redhat.com>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a man page entry for the update command, which is an alias for upgrade. It also includes several whitespace cleanups across the rpm-ostree.xml man page. The changes are good, improving documentation and code style. I've pointed out a minor typo in a line that was part of the whitespace cleanup and suggested a correction.

Found during Gemini review

Assisted-by: Gemini Code Assist
Signed-off-by: Micah Abbott <miabbott@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2025

@miabbott: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fcos-e2e f7f498c link true /test fcos-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jeckersb
Copy link
Collaborator

Hm unrelated to this PR but it looks like CI is failing because it's running out of disk space:

[2025-10-23T19:01:08.509Z] Oct 23 19:00:57 qemu0 kola-runext-container-image[2527]: time="2025-10-23T19:00:57Z" level=fatal msg="writing blob: adding layer with blob \"sha256:6eb0f6c1e56d5e6343aa68c93ab07426311e25f9d0026dd2e5167017c0e4f4e5\"/\"\"/\"sha256:d70525ec8634e6b0bad7f2887ebda0b2ae45a74651681807488025eb0beac4c4\": unpacking failed (error: exit status 1; output: write /sysroot/ostree/repo/objects/dc/d80bcd3f1f9be899b14c2c993319665136b6cb88753a6b85d6b17face2ed0f.file: no space left on device)"

@jmarrero
Copy link
Member

Hm unrelated to this PR but it looks like CI is failing because it's running out of disk space:

[2025-10-23T19:01:08.509Z] Oct 23 19:00:57 qemu0 kola-runext-container-image[2527]: time="2025-10-23T19:00:57Z" level=fatal msg="writing blob: adding layer with blob \"sha256:6eb0f6c1e56d5e6343aa68c93ab07426311e25f9d0026dd2e5167017c0e4f4e5\"/\"\"/\"sha256:d70525ec8634e6b0bad7f2887ebda0b2ae45a74651681807488025eb0beac4c4\": unpacking failed (error: exit status 1; output: write /sysroot/ostree/repo/objects/dc/d80bcd3f1f9be899b14c2c993319665136b6cb88753a6b85d6b17face2ed0f.file: no space left on device)"

#5518

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit a18998f into coreos:main Oct 25, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update subcommand is undocumented

3 participants