-
Notifications
You must be signed in to change notification settings - Fork 212
man: add an entry for the update alias #5515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Micah Abbott <miabbott@redhat.com>
Closes: coreos#5514 Signed-off-by: Micah Abbott <miabbott@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a man page entry for the update command, which is an alias for upgrade. It also includes several whitespace cleanups across the rpm-ostree.xml man page. The changes are good, improving documentation and code style. I've pointed out a minor typo in a line that was part of the whitespace cleanup and suggested a correction.
Found during Gemini review Assisted-by: Gemini Code Assist Signed-off-by: Micah Abbott <miabbott@redhat.com>
|
@miabbott: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hm unrelated to this PR but it looks like CI is failing because it's running out of disk space: |
|
jmarrero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Some whitespace cleanups too
Closes: #5514