Skip to content

Conversation

@cgwalters
Copy link
Member

Add the omitted lifetimes.

Add the omitted lifetimes.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a new lifetime-related lint introduced in Rust 1.89. The changes involve adding explicit lifetime annotations ('_) to types like Cow and Box<T> in function return types across several files. These modifications are accurate, minimal, and necessary for compatibility with the updated compiler version. The code quality is good, and the changes effectively resolve the linting issue.

Copy link
Collaborator

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦀

@cgwalters cgwalters enabled auto-merge October 7, 2025 18:48
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fcos-e2e a467fcf link true /test fcos-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cgwalters cgwalters merged commit ca4a8b0 into coreos:main Oct 7, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants