rechunker: Cleanup test state mid run #5505
Conversation
The github action is running out of disk space. Cleanup the images between tests to free up space. Signed-off-by: ckyrouac <ckyrouac@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds cleanup steps to the test script to free up disk space during the run, which is a good improvement. I've noticed a small redundancy in one of the cleanup commands and suggested a change to make it more precise. Otherwise, the changes look good.
| echo "ok exclusive layers functionality" | ||
|
|
||
| # Cleanup | ||
| podman rmi -f localhost/chunked localhost/modified localhost/exclusive-test localhost/exclusive-chunked |
There was a problem hiding this comment.
The images localhost/chunked and localhost/modified are already removed on line 114. This part of the test creates localhost/exclusive-test and localhost/exclusive-chunked, so the cleanup should only target those images to avoid redundancy.
| podman rmi -f localhost/chunked localhost/modified localhost/exclusive-test localhost/exclusive-chunked | |
| podman rmi -f localhost/exclusive-test localhost/exclusive-chunked |
|
@ckyrouac: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
The github action is running out of disk space. Cleanup the images between tests to free up space.