build(deps): bump libdnf from `998efa8` to `8eadf44` #5498

travier · 2025-09-26T16:35:39Z

See: https://bugzilla.redhat.com/show_bug.cgi?id=2372978
See: rpm-software-management/libdnf@8eadf44
Should fix: #5494

I have not tested this change yet.

It looks like dependabot stopped updating this submodule around July (edit: last year). I don't know why.

gemini-code-assist

Code Review

This pull request updates the libdnf submodule to commit 8eadf44 to resolve an issue with modular dependency handling. The change is a simple dependency bump. However, as noted in the description, this change has not yet been tested. Given that libdnf is a core dependency, it is critical to perform thorough testing to confirm that it resolves the intended issue and does not introduce any regressions before merging.

travier · 2025-09-26T16:54:02Z

C9S failure is due to an older librepo:

-- Checking for module 'librepo>=1.18.0'
  --   Package dependency requirement 'librepo >= 1.18.0' could not be satisfied.
  Package 'librepo' has version '1.14.5', required version is '>= 1.18.0'
  -- Configuring incomplete, errors occurred!

From rpm-software-management/libdnf@5449211

travier · 2025-09-26T16:54:48Z

Code style issue is:

16:36:21  error: Commit message for 3313d51d774a81b490060dca83e49a6444127c7c changes a submodule, but does not match regex Update submodule: libdnf

Will be fixed in the next push.

travier · 2025-09-26T16:58:19Z

C9S failure is due to an older librepo:

-- Checking for module 'librepo>=1.18.0'
  --   Package dependency requirement 'librepo >= 1.18.0' could not be satisfied.
  Package 'librepo' has version '1.14.5', required version is '>= 1.18.0'
  -- Configuring incomplete, errors occurred!

From rpm-software-management/libdnf@5449211

That probably means that we need to branch rpm-ostree for C9S with a libdnf bumped to the commit prior to this one.

travier · 2025-09-26T17:25:47Z

FCOS E2E failure looks weird:

Importing rpm-md...done
rpm-md repo 'fedora-coreos-pool'; generated: 2025-09-26T16:26:35Z solvables: 57868
rpm-md repo 'fedora'; generated: 2025-04-09T11:06:59Z solvables: 76879
rpm-md repo 'fedora-updates'; generated: 2025-09-26T01:02:13Z solvables: 24241
error: Installing packages: Packages not found: /usr/share/makedumpfile
failed to execute cmd-fetch: exit status 1

cgwalters · 2025-09-26T17:52:43Z

Yes this came up previously in #5140 (comment)

I'm OK to branch for rhel9.

cgwalters · 2025-09-26T18:02:20Z

#5500 will track the branching.

travier · 2025-10-20T12:36:23Z

/retest

travier · 2025-10-20T16:40:54Z

/retest

travier · 2025-10-20T16:41:50Z

🤔

Importing rpm-md...done
rpm-md repo 'fedora-coreos-pool'; generated: 2025-10-19T20:39:08Z solvables: 60869
rpm-md repo 'fedora'; generated: 2025-04-09T11:06:59Z solvables: 76879
rpm-md repo 'fedora-updates'; generated: 2025-10-20T00:59:12Z solvables: 25415
error: Installing packages: Packages not found: /usr/share/makedumpfile

travier · 2025-10-21T10:50:29Z

Build-chunked-oci failed on:

+ podman run --rm --privileged --security-opt=label=disable -v /var/lib/containers:/var/lib/containers -v /var/tmp:/var/tmp -v /home/runner/work/rpm-ostree/rpm-ostree/tests/build-chunked-oci:/output localhost/builder rpm-ostree compose build-chunked-oci --bootc --from quay.io/centos-bootc/centos-bootc:stream9 --output containers-storage:localhost/chunked-ppc64le --label foo=bar
rpm-ostree: error while loading shared libraries: librpm.so.10: cannot open shared object file: No such file or directory

castrojo · 2025-10-28T11:54:15Z

We're shipping this in Aurora, Bazzite, and Bluefin as of 15 hours ago: ublue-os/main#1600

We've had multiple confirmed users with locally layered packages that this fixes the issue. We'll have at least a few more thousand users over the course of the next few days to bang on it.

cgwalters · 2025-10-28T19:52:29Z

Thanks, we'll get this reviewed and merged soon!

cgwalters · 2025-10-29T12:27:47Z

OK so filelists. Holy cow. As linked from #5522 this pulls in https://fedoraproject.org/wiki/Changes/DNFConditionalFilelists

Except that actually because we had an old libdnf at the time, we basically implemented that behavior in a different way via 340f2aa which has its own knobs and configuration.

The complexity here comes in that basically I think what we want is to always enable filelists on the build side, and not the client side, and we need to work through how the libdnf change affects all the code paths invoking it.

cgwalters · 2025-10-29T15:07:56Z

Hummm....I think some of this is actually just quay.io/fedora/fedora-coreos:testing-devel revving to Fedora 43 just as of ~yesterday

cgwalters · 2025-10-30T14:17:10Z

OK first we need to land #5523

See: https://bugzilla.redhat.com/show_bug.cgi?id=2372978 See: rpm-software-management/libdnf@8eadf44 Should fix: coreos#5494 Signed-off-by: Colin Walters <walters@verbum.org>

As of libdnf 0.73.0 (commit f1ffeed5a75e902adf356c6cdfd926d6653b00ce), filelists metadata is disabled by default to optimize package resolution performance. However, this breaks file dependency resolution when packages specify file paths (e.g., /usr/share/makedumpfile) as dependencies. The previous code only explicitly disabled filelists when the SKIP_FILELISTS flag was set, relying on the old default of filelists being enabled. With the new libdnf default, we need to explicitly enable filelists when NOT skipping them. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>

cgwalters · 2025-10-31T15:20:32Z

OK now down to just one failure

 Oct 31 02:07:10 qemu0 kola-runext-layering-useradd[2210]: + grep testdaemon /etc/passwd /usr/lib/passwd
Oct 31 02:07:10 qemu0 kola-runext-layering-useradd[2210]: + rpm-ostree install /var/opt/kola/extdata/rpm-repos/0/packages/x86_64/rpmostree-openvpn-1.0-1.x86_64.rpm
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]: Checking out tree 7cb290a...done
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]: No enabled rpm-md repositories.
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]: Importing rpm-md...done
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]: Resolving dependencies...done
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]: error: Could not depsolve transaction; 1 problem detected:
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]:  Problem: conflicting requests
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]:   - nothing provides group(rpmostree-openvpn) needed by rpmostree-openvpn-1.0-1.x86_64 from @commandline
Oct 31 02:07:11 qemu0 kola-runext-layering-useradd[2491]:   - nothing provides user(rpmostree-openvpn) needed by rpmostree-openvpn-1.0-1.x86_64 from @commandline

Yet what has me baffled is this same test passes in Jenkins. There must be some environmental difference leaking in? I wonder if this is skew in the RPM version used at build time?

cgwalters · 2025-10-31T15:20:43Z

For now
/override ci/prow/fcos-e2e

openshift-ci · 2025-10-31T15:20:48Z

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

Details

In response to this:

For now
/override ci/prow/fcos-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jmarrero

lgtm

travier · 2025-11-13T23:13:03Z

Thanks for all the work fixing this one.

gemini-code-assist bot reviewed Sep 26, 2025

View reviewed changes

travier mentioned this pull request Sep 26, 2025

Fedora 43 Kinoite Beta failed to add subkeys for google-chrome #5494

Closed

travier force-pushed the main-bump-libdnf branch from 3313d51 to 2688125 Compare September 26, 2025 17:24

cgwalters mentioned this pull request Sep 26, 2025

branch for c9s #5500

Closed

travier force-pushed the main-bump-libdnf branch from 2688125 to 7a006dc Compare October 20, 2025 08:50

RoyalOughtness mentioned this pull request Oct 28, 2025

build(deps): update submodule: libdnf 998efa8 to 8eadf44 #5521

Closed

jmarrero force-pushed the main-bump-libdnf branch from 7a006dc to 746d1e7 Compare October 28, 2025 17:16

cgwalters force-pushed the main-bump-libdnf branch from 746d1e7 to 1b5bf7a Compare October 29, 2025 00:31

This comment was marked as off-topic.

Sign in to view

cgwalters force-pushed the main-bump-libdnf branch from 1b5bf7a to 4abd2dd Compare October 29, 2025 12:18

cgwalters mentioned this pull request Oct 29, 2025

fix: always pull filelists #5522

Closed

cgwalters force-pushed the main-bump-libdnf branch from 69575a2 to 0d3ca5b Compare October 30, 2025 20:21

travier and others added 2 commits October 30, 2025 21:02

Update submodule: libdnf 998efa8 to 8eadf44

3299e51

See: https://bugzilla.redhat.com/show_bug.cgi?id=2372978 See: rpm-software-management/libdnf@8eadf44 Should fix: coreos#5494 Signed-off-by: Colin Walters <walters@verbum.org>

jmarrero force-pushed the main-bump-libdnf branch from 0d3ca5b to 170e18d Compare October 31, 2025 01:03

cgwalters enabled auto-merge October 31, 2025 15:20

jmarrero approved these changes Oct 31, 2025

View reviewed changes

cgwalters merged commit d90f633 into coreos:main Oct 31, 2025
20 checks passed

travier deleted the main-bump-libdnf branch November 13, 2025 23:13

dustymabe mentioned this pull request Nov 20, 2025

Package layering using added repo fails with GPG key validation errors coreos/fedora-coreos-tracker#2068

Closed

build(deps): bump libdnf from 998efa8 to 8eadf44 #5498

build(deps): bump libdnf from 998efa8 to 8eadf44 #5498

Conversation

travier commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

travier commented Sep 26, 2025

Uh oh!

travier commented Sep 26, 2025

Uh oh!

travier commented Sep 26, 2025

Uh oh!

travier commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgwalters commented Sep 26, 2025

Uh oh!

cgwalters commented Sep 26, 2025

Uh oh!

travier commented Oct 20, 2025

Uh oh!

travier commented Oct 20, 2025

Uh oh!

travier commented Oct 20, 2025

Uh oh!

travier commented Oct 21, 2025

Uh oh!

castrojo commented Oct 28, 2025

Uh oh!

cgwalters commented Oct 28, 2025

Uh oh!

This comment was marked as off-topic.

cgwalters commented Oct 29, 2025

Uh oh!

cgwalters commented Oct 29, 2025

Uh oh!

cgwalters commented Oct 30, 2025

Uh oh!

cgwalters commented Oct 31, 2025

Uh oh!

cgwalters commented Oct 31, 2025

Uh oh!

openshift-ci bot commented Oct 31, 2025

Uh oh!

jmarrero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

travier commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

build(deps): bump libdnf from `998efa8` to `8eadf44` #5498

build(deps): bump libdnf from `998efa8` to `8eadf44` #5498

travier commented Sep 26, 2025 •

edited

Loading

travier commented Sep 26, 2025 •

edited

Loading