Skip to content

Remove /usr/local/man tempfile create #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cgwalters merged 1 commit into from
Sep 17, 2025
Merged

Remove /usr/local/man tempfile create #5491

cgwalters merged 1 commit into from
Sep 17, 2025
+0 −1

Conversation

@henrywang
Copy link
Contributor

@henrywang henrywang commented Sep 16, 2025 •
edited
Loading

This PR resolved rpm-ostree part of issue https://issues.redhat.com/browse/RHEL-106203.

I only remove /usr/local/man tempfile create in rpm-ostree, but I can't fix /home and /srv which is created by systemd https://github.com/systemd/systemd/blob/main/tmpfiles.d/home.conf

@henrywang
Remove /usr/local/man tempfile create
3313753 
Resolve rpm-ostree part of issue https://issues.redhat.com/browse/RHEL-106203

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2025

Hi @henrywang. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 16, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the creation of the /usr/local/man directory from the rpm-ostree-0-integration.conf configuration file. The change is straightforward and aligns with the PR's goal. I've reviewed the change and it appears correct, with no obvious side effects in the provided context. I have no further comments or suggestions.

@cgwalters
Copy link
Member

cgwalters commented Sep 17, 2025

I double checked this with what's in the quay.io/fedora/fedora:42 base image, and indeed it's just man that we are incorrectly adding.

@cgwalters cgwalters merged commit c8de7c6 into coreos:main Sep 17, 2025
17 checks passed
@henrywang henrywang deleted the fix_tempfile branch September 22, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henrywang @cgwalters