Ah yes we should probably use https://github.com/rpm-software-management/libdnf/commits/rhel-9.6 or so

Or of course switch to just cherry picking changes for rhel-9, or create a rhel-9 branch here upstream.

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

I can get the original error from:

FROM registry.fedoraproject.org/fedora-toolbox:40
RUN mkdir /development
WORKDIR /development
RUN dnf builddep ostree rpm-ostree clang -y
RUN git clone https://github.com/coreos/rpm-ostree.git && \
    cd /development/rpm-ostree && ./ci/clang-build-check.sh

Downgrading clag does nothing for me. Now that I can reproduce it in a container will try to find if there is any specific libdnf branch/commit that works.

So what bit me is the fact that we don't rebuild libdnf unless you make clean...build system bugs are the worst

Ummm...I think what happened here is rpm dropped support for pgp in rpm-software-management/rpm#2984

So there's no maintained libdnf that builds on both fedora and rhel9 which definitely puts us in a pickle. I dunno. I guess we could also just fork at this point.

So in theory in would be good to sync to this branch for rhel but for now let's put off that tech debt unless there's a reason to because it would force us to fork here which has nontrivial implications.

If we do do this PR we'll also want

diff --git a/rust/libdnf-sys/Cargo.toml b/rust/libdnf-sys/Cargo.toml
index f0a4c291..641c41ea 100644
--- a/rust/libdnf-sys/Cargo.toml
+++ b/rust/libdnf-sys/Cargo.toml
@@ -34,6 +34,7 @@ sqlite3 = "3"
 modulemd = { name = "modulemd-2.0", version = "2" }
 jsonc = { name = "json-c", version = "0" }
 glib = { name = "glib-2.0", version = "2" }
+libselinux = { version = "3.6" }
 zck = { version = "0.9", optional = true }
 librhsm = { version = "0.0.3", feature = "rhsm" }