The split_whitespace_unless_quoted function was using chars().enumerate()
which returns character indices, but then using those indices to slice
the string which requires byte indices. This triggers the
char_indices_as_byte_indices clippy lint.

Fixed by using char_indices() instead, which provides byte indices
directly. Also refactored the end-of-string handling to occur after
the loop completes, which is clearer and handles the remaining text
properly regardless of multi-byte characters.

Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters <walters@verbum.org>

Update the shared bootc-ubuntu-setup GitHub Action to match the latest
version from bootc-dev/bootc, incorporating several improvements:

- Add libvirt input parameter: Allows workflows to optionally install
  virtualization stack for tests that need VM support
- Improve disk cleanup: Use systemd-run for parallel background cleanup
  operations, freeing disk space more efficiently
- Add timing instrumentation: Use /bin/time to track duration of
  expensive operations (apt update, apt install)
- Add Rust caching: Use Swatinem/rust-cache@v2 for faster builds with
  intelligent cache management (only save on main, lookup-only on main
  to avoid incremental bugs)
- Add libvirt support: Install bcvk, qemu, and related virtualization
  tools when libvirt input is true
- Add cleanup status: Display systemd cleanup units and final disk
  usage for better observability

These changes bring rpm-ostree's CI infrastructure more in line with
bootc's battle-tested setup, enabling future enhancements like VM-based
integration tests.

Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters <walters@verbum.org>

Fix static library linking order in libdnf-sys build script.
The C++ wrapper (libdnfcxx.a) depends on both libdnf and glib,
but cargo's link order requires dependencies to come after
dependents. Re-emit link directives after compiling the wrapper
to ensure symbols are available.

This was causing undefined reference errors for g_strndup, g_free,
and hy_split_nevra when building tests.

Also add workspace-level lints to Cargo.toml and minor Rust cleanups.

Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters <walters@verbum.org>

This introduces a Justfile and Dockerfile to enable building rpm-ostree
from source in a container, following the pattern established in the
bootc project.

See the `Justfile` for key entrypoints. Those are now used
in a new GHA flow, which we'll try to move things over to.

A key difference though vs bootc is because rpm-ostree has a lot
of C++ too we use sccache which greatly speeds things up across
incremental rebuilds.

Just one side cleanup of this is before it was *terribly*
painful and manual to hack on `test-container.sh`, and now it's easy,
fast and optimized.

Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters <walters@verbum.org>

In the work to rebase FCOS/RHCOS to fedora-bootc/rhel-bootc, we want to
run postprocess scripts for CoreOS specific changes to the rootfs, but
we want changes made in those postprocess scripts to affect the
initramfs generation too.

The new experimental `no-initramfs` knob will allow us to disable the
generation of the initramfs via dracut in the initial compose of the
rootfs. Then we can run our postprocess scripts on the rootfs and later
run dracut to generate the initramfs.

This came from discussion in https://gitlab.com/fedora/bootc/base-images/-/merge_requests/315
where it was decided to not add a `--postprocess` argument to bootc-base-imagectl.

Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>

With the no-initramfs treefile knob the underlying code that normalizes
/etc/shadow when dracut is run isn't getting called. Let's just call it
unconditionally here.

This yielded a diff like the following when this function wasn't getting
called:

```
$ diff -ur tmp/diff-cache/metal/43.20251104.dev.{0,1}/ostree/deploy/fedora-coreos/deploy/XXXXXXXXXXXXXXXX.0/etc/shadow
--- tmp/diff-cache/metal/43.20251104.dev.0/ostree/deploy/fedora-coreos/deploy/XXXXXXXXXXXXXXXX.0/etc/shadow     2022-08-01 19:42:11.000000000 -0400
+++ tmp/diff-cache/metal/43.20251104.dev.1/ostree/deploy/fedora-coreos/deploy/XXXXXXXXXXXXXXXX.0/etc/shadow     2022-08-01 19:42:11.000000000 -0400
@@ -30,9 +30,9 @@
 systemd-resolve:*::0:99999:7:::
 systemd-timesync:*::0:99999:7:::
 tcpdump:*::0:99999:7:::
-zincati:!*:::::::
-clevis:!*:::::::
-dnsmasq:!*:::::::
-systemd-coredump:!*:::::::
-systemd-oom:!*:::::::
-tss:!*:::::::
+zincati:!*:20396::::::
+clevis:!*:20396::::::
+dnsmasq:!*:20396::::::
+systemd-coredump:!*:20396::::::
+systemd-oom:!*:20396::::::
+tss:!*:20396::::::
```

treefile: Add `no-initramfs:` knob

Add build+test infra mirroring bootc

feat: replace unmaintained paste with maintained pastey

Avoid allocating in `pre_exec` closure

When booted from a container image, skip the base commit rpmdb check
during package installation transactions. Container images don't have
meaningful base-db separation like traditional ostree commits do.

This fixes idempotent layering on booted hosts when deployed via
container, where packages already present in the base image would
incorrectly fail.  Now, if the DNF transaction is empty (all packages
already in base), we properly exit cleanly.

Also adds tests for idempotent layering scenarios with container
images.

Signed-off-by: Joseph Marrero Corchado <jmarrero@redhat.com>

rpmostreed-transaction-types: don't use base-db when idempotent

Update links to use current docs site