libdnf: Explicitly enable filelists for non-SKIP_FILELISTS flows

cgwalters · cgwalters · commit 0d3ca5babe0d · 2025-10-30T16:20:46.000-04:00
As of libdnf 0.73.0 (commit f1ffeed5a75e902adf356c6cdfd926d6653b00ce),
filelists metadata is disabled by default to optimize package resolution
performance. However, this breaks file dependency resolution when packages
specify file paths (e.g., /usr/share/makedumpfile) as dependencies.

The previous code only explicitly disabled filelists when the
SKIP_FILELISTS flag was set, relying on the old default of filelists
being enabled. With the new libdnf default, we need to explicitly enable
filelists when NOT skipping them.

Assisted-by: Claude Code (Sonnet 4.5)
Signed-off-by: Colin Walters &lt;walters@verbum.org&gt;
diff --git a/src/libpriv/rpmostree-core.cxx b/src/libpriv/rpmostree-core.cxx
@@ -971,9 +971,13 @@ rpmostree_context_download_metadata (RpmOstreeContext *self, DnfContextSetupSack
 
   /* https://github.com/rpm-software-management/libdnf/pull/416
    * https://github.com/projectatomic/rpm-ostree/issues/1127
+   * As of libdnf 0.73.0 (commit f1ffeed5), filelists are disabled by default.
+   * We need to explicitly enable them when not skipping.
    */
   if (flags & DNF_CONTEXT_SETUP_SACK_FLAG_SKIP_FILELISTS)
     dnf_context_set_enable_filelists (self->dnfctx, FALSE);
+  else
+    dnf_context_set_enable_filelists (self->dnfctx, TRUE);
 
   g_autoptr (GPtrArray) rpmmd_repos
       = rpmostree_get_enabled_rpmmd_repos (self->dnfctx, DNF_REPO_ENABLED_PACKAGES);
