rcv: RcvDetalleEntry.as_dte_data_l2() does not work when tipo DTE is a "Nota"
#952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtrobles-cdd
changed the title
RcvDetalleEntry.as_dte_data_l2() does not work for 'Notas'RcvDetalleEntry.as_dte_data_l2() does not work when tipo DTE is a "Nota"
When the "tipo DTE" of a `RcvDetalleEntry` is a "nota" (e.g. "nota de crédito electrónica"), the `as_dte_data_l2()` method throws an exception because it does not know how to determine the `emisor` and `receptor` of the DTE.
jtrobles-cdd
force-pushed
the
fix-rcv-detalle-entry-to-dtedata
branch
from
3b68dad to
9637330
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #952 +/- ##
===========================================
- Coverage 88.26% 88.03% -0.24%
===========================================
Files 40 40
Lines 3793 3803 +10
Branches 396 398 +2
===========================================
Hits 3348 3348
- Misses 290 300 +10
Partials 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "tipo DTE" of a
RcvDetalleEntryis a "nota" (e.g. "nota de crédito electrónica"), theas_dte_data_l2()method throws an exception because it does not know how to determine theemisorandreceptorof the DTE.Ref: #949