Merged
Conversation
ja9-look
approved these changes
Apr 26, 2023
Contributor
ja9-look
left a comment
ja9-look
left a comment
There was a problem hiding this comment.
Only very minor typos but apart from that, LGTM
| // Bid Contract Verification Logic goes here | ||
| if(tx.getInputStates().size() != 1) throw new IllegalArgumentException("One Input Expected"); | ||
| if(tx.getOutputStates().size() != 1) throw new IllegalArgumentException("One Output Expected"); | ||
| if(tx.getInputStates().size() != 2) throw new IllegalArgumentException("Two Input Expected"); |
Contributor
There was a problem hiding this comment.
"Two Inputs Expected" and "Two Outputs Expected"
|
|
||
| if(!expiryInput.getAuctionId().equals(expiryOutput.getAuctionId()) && | ||
| !expiryInput.getParticipants().equals(expiryOutput.getParticipants())){ | ||
| throw new IllegalArgumentException("Auction Id and Par should not change while placing a bid"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.