chore: do not continue with no_reply messages (microsoft#1905)

mxschmitt · web-flow · commit 7405d655bfcd · 2023-05-09T21:34:30.000+02:00
diff --git a/playwright/_impl/_connection.py b/playwright/_impl/_connection.py
@@ -68,9 +68,10 @@ async def send_return_as_dict(self, method: str, params: Dict = None) -> Any:
         )
 
     def send_no_reply(self, method: str, params: Dict = None) -> None:
+        # No reply messages are used to e.g. waitForEventInfo(after).
         self._connection.wrap_api_call_sync(
             lambda: self._connection._send_message_to_server(
-                self._guid, method, {} if params is None else params
+                self._guid, method, {} if params is None else params, True
             )
         )
 
@@ -178,6 +179,7 @@ def remove_listener(self, event: str, f: Any) -> None:
 class ProtocolCallback:
     def __init__(self, loop: asyncio.AbstractEventLoop) -> None:
         self.stack_trace: traceback.StackSummary
+        self.no_reply: bool
         self.future = loop.create_future()
         # The outer task can get cancelled by the user, this forwards the cancellation to the inner task.
         current_task = asyncio.current_task()
@@ -305,7 +307,7 @@ def set_in_tracing(self, is_tracing: bool) -> None:
             self._tracing_count -= 1
 
     def _send_message_to_server(
-        self, guid: str, method: str, params: Dict
+        self, guid: str, method: str, params: Dict, no_reply: bool = False
     ) -> ProtocolCallback:
         if self._closed_error_message:
             raise Error(self._closed_error_message)
@@ -317,6 +319,7 @@ def _send_message_to_server(
             traceback.StackSummary,
             getattr(task, "__pw_stack_trace__", traceback.extract_stack()),
         )
+        callback.no_reply = no_reply
         self._callbacks[id] = callback
         stack_trace_information = cast(ParsedStackTrace, self._api_zone.get())
         frames = stack_trace_information.get("frames", [])
@@ -357,6 +360,10 @@ def dispatch(self, msg: ParsedMessagePayload) -> None:
             callback = self._callbacks.pop(id)
             if callback.future.cancelled():
                 return
+            # No reply messages are used to e.g. waitForEventInfo(after) which returns exceptions on page close.
+            # To prevent 'Future exception was never retrieved' we just ignore such messages.
+            if callback.no_reply:
+                return
             error = msg.get("error")
             if error:
                 parsed_error = parse_error(error["error"])  # type: ignore
