Extend hyperlink decoration documentation #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
is there anything more that needs to be done ? |
uspasojevic96
added
the
no changelog
|
why are some checks getting failed , what can I do to make it work ? |
|
You can address the editorconfig checks, when you click on Details of that check you will see what needs to be changed, everything else is fine |
|
i have made changes to the .gitignore file |
They're not running because only src/ has not been touched. We maybe should tweak that outside of that PR at some point. |
christianparpart
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1437
Describe your changes in detail
Motivation and Context
Why is this change required? What problem does it solve?
How Has This Been Tested?
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.If you're unsure about any of these, don't hesitate to ask. We're here to help!
CONTRIBUTINGdocument in my spoken language, and understand the terms