Adapt to code review changes

christianparpart · christianparpart · commit 7467a305594f · 2025-11-02T18:28:59.000+01:00
Signed-off-by: Christian Parpart &lt;christian@parpart.family&gt;
diff --git a/src/vtbackend/Screen.cpp b/src/vtbackend/Screen.cpp
@@ -1762,11 +1762,11 @@ void Screen<Cell>::requestAnsiMode(unsigned int mode)
 template <CellConcept Cell>
 void Screen<Cell>::requestDECMode(unsigned int mode)
 {
-    auto const modeEnum = fromDECModeNum(mode);
-
-    auto const modeResponse = [&]() -> ModeResponse {
+    auto const modeResponse = [this, mode]() -> ModeResponse {
+        auto const modeEnum = fromDECModeNum(mode);
         if (modeEnum.has_value())
         {
+            auto const modeEnum = fromDECModeNum(mode);
             if (_terminal->isModeEnabled(modeEnum.value()))
                 return ModeResponse::Set;
             else
diff --git a/src/vtbackend/primitives.h b/src/vtbackend/primitives.h
@@ -833,8 +833,8 @@ constexpr std::optional<DECMode> fromDECModeNum(unsigned int modeNum) noexcept
         case 2030: return DECMode::ReportGridCellSelection;
         case 2031: return DECMode::ReportColorPaletteUpdated;
         case 8452: return DECMode::SixelCursorNextToGraphic;
+        default: return std::nullopt;
     }
-    return std::nullopt;
 }
 
 constexpr bool isValidDECMode(unsigned int mode) noexcept

Original file line number	Diff line number	Diff line change
`@@ -833,8 +833,8 @@ constexpr std::optional<DECMode> fromDECModeNum(unsigned int modeNum) noexcept`
`833`	`833`	`case 2030: return DECMode::ReportGridCellSelection;`
`834`	`834`	`case 2031: return DECMode::ReportColorPaletteUpdated;`
`835`	`835`	`case 8452: return DECMode::SixelCursorNextToGraphic;`
	`836`	`+ default: return std::nullopt;`
`836`	`837`	`}`
`837`		`- return std::nullopt;`
`838`	`838`	`}`
`839`	`839`
`840`	`840`	`constexpr bool isValidDECMode(unsigned int mode) noexcept`