Add division check for debug mode #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaraslaut
force-pushed
the
improvement/runtime_division_check_in_debug
branch
3 times, most recently
from
06e04c4 to
a523489
Compare
christianparpart
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
this looks like something similar i had in mind as well.
I however thought about generic validators for assignment. this would not work for guarding against division though. I agree.
General validation would only make sense if the user of boxed-cpp pays if and only if validation was requested (meant to be present). If no validation is required, then no code should be generated. 🤔 (future work ideas) :)
Yaraslaut
force-pushed
the
improvement/runtime_division_check_in_debug
branch
from
a523489 to
52e0033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds check of division for integral types when build with debug mode