add php56 support + jinja2 templating to php modules#30
add php56 support + jinja2 templating to php modules#30Farouk-Lamri merged 25 commits intomasterfrom
Conversation
…e-containers into feat/php-56-support
Pierozi
left a comment
There was a problem hiding this comment.
I think you will have issue regarding the deployment of runtime php_custom.
check the ci script https://github.com/continuousphp/runtime-containers/blob/master/bin/ci.sh#L65-L69
The name of the image build locally and the tag does not match due to the fact that the script was design only for one runtime... must adapt it but still pushed to the same ECR in case of php...
Should be ok now. Conversion to semantic versioning is now done when building the image, and the ci script is using the FYI: I performed tests in order to consider php < 5.6.40 as a 'normal' php runtime, which is loading another image than php > 7.0, this would make more sense for the users and would avoid having two php runtimes named differently. |
7f44662
#Add PHP 56 support + jinja2 templating to php-modules definition
/runtime-containers/components/php_modules/deb/php_modules.j2replaces/runtime-containers/components/php_modules/deb/php_modules.dtcas asked in DTC Jinja template #17