feat(cli): curl/irl installation scripts and docs#9835
Open
feat(cli): curl/irl installation scripts and docs#9835
Conversation
RomneyDa
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:XL
|
✅ Review Complete Code Review Summary |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/scripts/install.sh">
<violation number="1" location="extensions/cli/scripts/install.sh:149">
P2: `set -u` plus unguarded `$FNM_DIR` expansion in `source_fnm` will abort the installer when FNM_DIR is unset.</violation>
<violation number="2" location="extensions/cli/scripts/install.sh:182">
P2: Cleanup can remove an existing fnm installation because CLEANUP_FNM is set unconditionally without tracking whether the install directory pre-existed.</violation>
</file>
<file name="extensions/cli/scripts/install.ps1">
<violation number="1" location="extensions/cli/scripts/install.ps1:173">
P2: Direct-download fnm install only updates the current session PATH; no persistent PATH update is written, so new shells may not find `fnm` and the profile init will fail after restart.</violation>
<violation number="2" location="extensions/cli/scripts/install.ps1:274">
P2: User-local npm prefix is only added to the current session PATH; after restarting PowerShell the CLI may not be on PATH, so `cn` can be missing despite a successful install.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Fix CLEANUP_FNM to only mark for cleanup if fnm dir doesn't pre-exist - Guard FNM_DIR expansion with parameter substitution to avoid set -u errors - Persist fnm PATH to user environment in PowerShell for future sessions - Persist npm global bin PATH to user environment in PowerShell Co-authored-by: dallin <dallin@continue.dev> Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
…t-perform-those-actions-for-you- fix: address code review comments for installation scripts
Contributor
There was a problem hiding this comment.
2 issues found across 19 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/README.md">
<violation number="1" location="extensions/cli/README.md:12">
P2: Docs now recommend `curl|bash`/`irm|iex` of scripts from the moving `main` branch without pinning or integrity verification, which creates a supply‑chain risk and non‑reproducible installs.</violation>
</file>
<file name="docs/guides/posthog-github-continuous-ai.mdx">
<violation number="1" location="docs/guides/posthog-github-continuous-ai.mdx:1">
P2: Frontmatter delimiter is corrupted (`20---`), so the YAML metadata won’t be parsed as frontmatter and can break MDX metadata/builds.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/snippets/OSAutoDetect.jsx">
<violation number="1" location="docs/snippets/OSAutoDetect.jsx:15">
P2: Linux user agents are not detected, so they’ll default to the npm tab even though the comment says macOS/Linux should map to tab 0. Add a Linux check so Linux users see the intended tab.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Collaborator
Author
|
squash and merge this preferabiy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continue Tasks:▶️ 1 queued · ✅ 1 no changes · ✅ 1 merged — View all
Summary by cubic
Adds cross-platform one-line installers for Continue CLI that auto-install Node.js 20+ when needed and streamline setup. Updates docs to auto-detect OS and show the right command, making onboarding faster.
Written for commit 589caab. Summary will update on new commits.