Add support for ipc option in services element#1452
Open
wiehe wants to merge 3 commits into
Open
Conversation
podman create specification: https://docs.podman.io/en/stable/markdown/podman-create.1.html#ipc-ipc compose specification: https://github.com/compose-spec/compose-spec/blob/main/05-services.md#ipc Fixes containers#218 and containers#1292 Signed-off-by: wiehe <28457227+wiehe@users.noreply.github.com>
Improve tests: - 1 new test case - additional checks for existing test cases Signed-off-by: wiehe <28457227+wiehe@users.noreply.github.com>
Print nicer error message if the service name in "ipc: service:name" is invalid. (Instead of just throwing a KeyError.) Signed-off-by: wiehe <28457227+wiehe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I propose the following patch, which takes the
ipcoption from aserviceselement in the composefile and passes it to podman as an--ipcoption.Motivation
What does work
Passing IPC options to
podman run/podman create.All modes specified by podman create/podman run and docker compose are supported.
""container:<name>hostnonens:<path>privateshareableservice:<name>(gets translated tocontainer:<id>)What does not work
Setting the IPC mode for
RUNinstructions when executing podman build.That would require a different
ipcoption, which would be located in thebuildelement. But such an option does not exist in the compose specification.