Add return type annotation for Construct.sizeof#1117
Open
laomaiweng wants to merge 1 commit intoconstruct:masterfrom
Open
Add return type annotation for Construct.sizeof#1117laomaiweng wants to merge 1 commit intoconstruct:masterfrom
laomaiweng wants to merge 1 commit intoconstruct:masterfrom
Conversation
The default implementation of `Construct.sizeof` unconditionally raises a `SizeofError`, because it is meant to be overridden in subclasses. This confuses some type checkers (e.g., pyright) which incorrectly infer `Construct.sizeof` to not return (assigning the `NoReturn` return type). Explicitly set the return type hint for `Construct.sizeof` to `int`, so that pyright correctly deals with this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default implementation of
Construct.sizeofunconditionally raises aSizeofError, because it is meant to be overridden in subclasses. This confuses some type checkers (e.g., pyright) which incorrectly (from construct's point-of-view) inferConstruct.sizeofto not return, assigning it theNoReturnreturn type.Explicitly set the return type hint for
Construct.sizeoftoint, so that pyright correctly deals with this function.