Update _emitfulltype for Bytes to export lengths if Paths are passed in#1031
Open
wbarnha wants to merge 2 commits intoconstruct:masterfrom
Open
Update _emitfulltype for Bytes to export lengths if Paths are passed in#1031wbarnha wants to merge 2 commits intoconstruct:masterfrom
wbarnha wants to merge 2 commits intoconstruct:masterfrom
Conversation
…in as lengths While exporting `Bytes(this.insert_name_here)`, I encountered `cannot represent an object: this['insert_name_here']` since `_emitfulltype` can't support `Path` objects being passed in as lengths. While this isn't the most graceful solution, I figured it'd be worth opening discussion on this. Are there any other classes that have similar methods that should have their `_emitfulltype` methods needing to be similarly updated as well?
Member
|
I will not accept this PR for two simple reasons. First being, I totally dont understand how KSY files work. Unless the grey cat on the tree himself sanctions this, then maybe. Second is its hackey as heck. |
Author
|
I totally agree at how disgusting it is, I'd be happy to change that when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While exporting
Bytes(this.insert_name_here), I encounteredcannot represent an object: this['insert_name_here']since_emitfulltypecan't supportPathobjects being passed in as lengths. While this isn't the most graceful solution, I figured it'd be worth opening discussion on this. Are there any other classes that have similar methods that should have their_emitfulltypemethods needing to be similarly updated as well?