Resolve lambdas in Container __getattr__#1030
Open
ev1313 wants to merge 1 commit intoconstruct:masterfrom
Open
Resolve lambdas in Container __getattr__#1030ev1313 wants to merge 1 commit intoconstruct:masterfrom
ev1313 wants to merge 1 commit intoconstruct:masterfrom
Conversation
JayFoxRox
reviewed
Jul 2, 2023
| "bar" / Rebuild(Int32ul, lambda ctx: ctx.baz), | ||
| "baz" / Rebuild(Int32ul, lambda ctx: ctx.foo), | ||
| ) | ||
| obj = {"foo": 4, "bar": lambda ctx: ctx.baz, "baz": lambda ctx: ctx.foo} |
There was a problem hiding this comment.
Why isn't this just {"foo": 4}? Asked differently: Why are "bar" and "baz" functions?
I think it's a bit hacky to allow the data to decide how it should be processed (~ functions). I'm not sure if there's a precedent for this in construct.
Instead, the lambda ctx: ctx.baz in Rebuild should be deferred until ctx.baz is available.
Is there an actual benefit doing it the proposed way (allowing functions in input to build) over deferring Rebuild?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently using Rebuild is only useful when parsing, because the dictionary gets filled with value copys:
However this isn't useful when building, because you don't know in later stages about the rebuilding, and when the parameters change, you'd need to change all of them.
With this change it is possible to put
lambda ctx: ctx.foointo the Container, which get resolved immediately, when accessed. (See the test case)This could be expanded upon, so that Rebuild itself just add these to the Container when parsing, or that a possible preprocessing step adds these before building.
The inspect hack is necessary to not break the existing behaviour of Lazy adding lambdas into the Container, which get resolved and return not the lambda, but the resulting value directly.