Add _emitfulltype to Optional and _emitprimitivetype to Peek#1029
Open
wbarnha wants to merge 3 commits intoconstruct:masterfrom
Open
Add _emitfulltype to Optional and _emitprimitivetype to Peek#1029wbarnha wants to merge 3 commits intoconstruct:masterfrom
wbarnha wants to merge 3 commits intoconstruct:masterfrom
Conversation
I'm in the process of exporting Structs to Kaitai schemas, and the `Optional` field is something I use very often. I figure that since `Optional` is typically parsed only when data is available, then using `not _.io.eof` could be used to achieve similar functionality. Or is there something else I'm missing here?
wbarnha
changed the title
|
Correct me when i am wrong, but i do believe the Optional is not limited to EOF situations. However, it is a common purpose, and different to the more general current Optional, it is translateable to kaitai. Maybe we should add an option, or make a OnlyIfDataExists alternative? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm in the process of exporting Structs to Kaitai schemas, and the
Optionalfield is something I use very often.I figure that since
Optionalis typically parsed only when data is available, then usingnot(_.io.eof)could be used to achieve similar functionality. Or is there something else I'm missing here?