Fixes version number wackiness when alternatives are changed

philnash · philnash · commit 2eeecba68f64 · 2012-08-09T14:45:21.000+01:00
I found that when I updated the alternatives in a test it kept resetting. I must have not noticed for a while, because when I checked, I was on version 30,561 yet had no results.
It turned out that when you save an existing experiment, it didn't update the alternatives, so that's what I've added.
diff --git a/lib/split/experiment.rb b/lib/split/experiment.rb
@@ -98,6 +98,9 @@ def save
         Split.redis.sadd(:experiments, name)
         Split.redis.hset(:experiment_start_times, @name, Time.now)
         @alternatives.reverse.each {|a| Split.redis.lpush(name, a.name) }
+      else
+        Split.redis.del(name)
+        @alternatives.reverse.each {|a| Split.redis.lpush(name, a.name) }
       end
     end
 
@@ -137,10 +140,11 @@ def self.find_or_create(key, *alternatives)
       alts = initialize_alternatives(alternatives, name)
 
       if Split.redis.exists(name)
-        if load_alternatives_for(name) == alts.map(&:name)
+        existing_alternatives = load_alternatives_for(name)
+        if existing_alternatives == alts.map(&:name)
           experiment = self.new(name, *alternatives)
         else
-          exp = self.new(name, *load_alternatives_for(name))
+          exp = self.new(name, *existing_alternatives)
           exp.reset
           exp.alternatives.each(&:delete)
           experiment = self.new(name, *alternatives)
diff --git a/spec/experiment_spec.rb b/spec/experiment_spec.rb
@@ -176,6 +176,15 @@
       new_blue = Split::Alternative.new('blue', 'link_color')
       new_blue.participant_count.should eql(0)
     end
+
+    it "should only reset once" do
+      experiment = Split::Experiment.find_or_create('link_color', 'blue', 'red', 'green')
+      experiment.version.should eql(0)
+      same_experiment = Split::Experiment.find_or_create('link_color', 'blue', 'yellow', 'orange')
+      same_experiment.version.should eql(1)
+      same_experiment_again = Split::Experiment.find_or_create('link_color', 'blue', 'yellow', 'orange')
+      same_experiment_again.version.should eql(1)
+    end
   end
 
   describe 'alternatives passed as non-strings' do
