Updated dynamic for task to set params in right way#352
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
nthmost-orkes
approved these changes
Oct 23, 2025
nthmost-orkes
left a comment
nthmost-orkes
left a comment
Contributor
There was a problem hiding this comment.
makes sense, thanks!
|
Looks like this issue is back again: https://github.com/conductor-oss/python-sdk/blob/main/src/conductor/client/workflow/task/dynamic_fork_task.py#L23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Updated DynamicForkTask to set parameters without validation issues
Added Integration tests to cover fix
Reason:
#349