Moodle: Prepare for an upcoming change in Moodle distribution #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
moodlepublic
branch
from
0ce4049 to
476e310
Compare
Author
|
Hi @Seldaek, I just wanted to check if we're still ok to go for this approach (submitting patches for the Composer installer), or would you recommend we roll our own plugin which is specific to Moodle? I note that the recommendation in Composer docs is to use the new Composer API to access plugins by type from the vendor directory, but sadly we're some time away from being able to do this (though it is on my radar). I also note that there is a related PR (#550) which has been waiting for PR for some time and this project has not seen a patch for some time. Cheers |
andrewnicols
force-pushed
the
moodlepublic
branch
from
476e310 to
b1a2451
Compare
This set of changes adds support for: - the 'public' directory introduced in Moodle 5.1 - the ability for Moodle to be installed as a Composer dependency - configuration of an installation-specific prefix for the Moodle 'core' path I've also: - updated the plugin type list for Moodle 5.1 - removed the `admin_report` plugin type which has not been a valid plugin type for about 15 years.
andrewnicols
force-pushed
the
moodlepublic
branch
from
b1a2451 to
3fbe06d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am the Principal Architect for Moodle and I'm tryign to move Moodle to officially support installation via Composer.
This set of changes adds support for:
I've also:
admin_reportplugin type which has not been a valid plugin type for about 15 years.