Skip to content

Conversation

@RitikaPahwa4444
Copy link
Collaborator

@RitikaPahwa4444 RitikaPahwa4444 commented Oct 21, 2025

Description (required)

Updates #3364

What changes did you make and why?

Disabled hardware acceleration and keyboard animation temporarily for v6.1.0 release.

Tests performed (required)

Tested prodDebug on moto g34 5G with API level 34 and Pixel 6 emulator with API level 31.

Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@RitikaPahwa4444 RitikaPahwa4444 marked this pull request as ready for review October 22, 2025 08:17
@rohit9625
Copy link
Collaborator

The UI shifts upward correctly without animation at the Upload Screen. However, it doesn't seem to be working well for Login Screen. I think that thesetOnApplyWindowInsetsListener is not working as expected.

Screen_recording_20251022_135826.mp4

It worked for UploadActivity because you added android:windowSoftInputMode="adjustPan". I would suggest doing the same for LoginActivity. It doesn't make any difference when I tried, probably because of my screen size, but it's fine as long as the input field is visible.f

Copy link
Collaborator

@rohit9625 rohit9625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@RitikaPahwa4444
Copy link
Collaborator Author

RitikaPahwa4444 commented Oct 22, 2025

Yeah, missed the adjustPan setting on login screen. Honestly speaking, adjustResize never worked well for me on main so that was the first thing I ended up changing. Thank you for pointing that out, let me try that on login screen too.

@rohit9625
Copy link
Collaborator

rohit9625 commented Oct 22, 2025

Yeah, missed the adjustPan setting on login screen. Honestly speaking, adjustResize never worked well for me on main so that was the first thing I ended up changing. Thank you for pointing that out, let me try that on login screen too.

No problem :)
Also, try to test on small screen size. Because on large screen it won't push the UI upwards if input are clearly visible when the keyboard is opened.

@RitikaPahwa4444
Copy link
Collaborator Author

UI pushed upwards -> the text area is never visible at all in the upload activity while I'm typing the caption. I'm referring to the main branch. As long as the text area is visible, I think we're good. What's your take on this?

@rohit9625
Copy link
Collaborator

UI pushed upwards -> the text area is never visible at all in the upload activity while I'm typing the caption. I'm referring to the main branch. As long as the text area is visible, I think we're good. What's your take on this?

I also tested on main, and the text is always visible while typing the caption, and the same for this branch. What are you referring to?

@RitikaPahwa4444
Copy link
Collaborator Author

screen-20251022-145334.mp4

Main branch for me :')

@rohit9625
Copy link
Collaborator

Ohh, this is because of the preview card at the top, I didn't test that on multi-upload. To avoid that we can use z-index if it works. Can you please try and confirm?

Copy link
Collaborator

@rohit9625 rohit9625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works as expected :)

Screen_recording_20251022_163443.mp4

@RitikaPahwa4444
Copy link
Collaborator Author

Thanks @rohit9625 for a quick review. Will send a beta release for approval and observe if it fixes the issue 🤞🏻

@RitikaPahwa4444 RitikaPahwa4444 merged commit 2d0255e into main Oct 22, 2025
1 of 2 checks passed
@github-actions
Copy link

✅ Generated APK variants!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants