-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Disable hardware acceleration and keyboard animation #6535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a temporary commit to see if it fixes issue #3364
|
The UI shifts upward correctly without animation at the Upload Screen. However, it doesn't seem to be working well for Login Screen. I think that the Screen_recording_20251022_135826.mp4It worked for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
|
Yeah, missed the adjustPan setting on login screen. Honestly speaking, adjustResize never worked well for me on main so that was the first thing I ended up changing. Thank you for pointing that out, let me try that on login screen too. |
No problem :) |
|
UI pushed upwards -> the text area is never visible at all in the upload activity while I'm typing the caption. I'm referring to the main branch. As long as the text area is visible, I think we're good. What's your take on this? |
I also tested on main, and the text is always visible while typing the caption, and the same for this branch. What are you referring to? |
screen-20251022-145334.mp4Main branch for me :') |
|
Ohh, this is because of the preview card at the top, I didn't test that on multi-upload. To avoid that we can use z-index if it works. Can you please try and confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and works as expected :)
Screen_recording_20251022_163443.mp4
|
Thanks @rohit9625 for a quick review. Will send a beta release for approval and observe if it fixes the issue 🤞🏻 |
|
✅ Generated APK variants! |
Description (required)
Updates #3364
What changes did you make and why?
Disabled hardware acceleration and keyboard animation temporarily for v6.1.0 release.
Tests performed (required)
Tested prodDebug on moto g34 5G with API level 34 and Pixel 6 emulator with API level 31.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.