fix(i18n): Correct capitalization for 'Sending thanks' status messages (#6515) #6518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
approved these changes
Oct 17, 2025
| <!--accessibility UI description strings--> | ||
| <string name="commons_facebook">Commons Facebook Page</string> | ||
| <string name="commons_github">Commons Github Source Code</string> | ||
| <string name="commons_github">Commons GitHub Source Code</string> |
| <string name="send_thank_failure_title">Sending thanks: Failure</string> | ||
|
|
||
| <string name="send_thank_toast">Sending Thanks for %1$s</string> | ||
| <string name="send_thank_toast">Sending thanks for %1$s</string> |
There was a problem hiding this comment.
Good job finding different patterns of this bug, rather than just what I wrote in the bug description!
|
Thank you @nicolas-raoul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (#6515)
This Pull Request resolves a minor capitalization inconsistency in the "Send Thanks" status messages. The capitalization was corrected to align with the application's standard Sentence Case convention for UI text.
Type of change
Description and Changes Made
The issue was in the file strings.xml ,where it was visible in the lines 496,499 and 501 and action taken are:
send_thank_success_title"Sending **T**hanks: Success""Sending **t**hanks: Success"send_thank_failure_title"Sending **T**hanks: Failure""Sending **t**hanks: Failure"send_thank_toast"Sending **T**hanks for %1$s""Sending **t**hanks for %1$s"Checklist
(Ensure you check all these boxes before submitting)