Skip to content

Conversation

@DeKaN
Copy link
Contributor

@DeKaN DeKaN commented Oct 12, 2025

Description (required)

Fixes #6464

The app doesn't crash for bookmarks without description or thumbnail. Also, the changed code was rewritten in Kotlin style

Tests performed (required)

Tests for the class ran successfully

@nicolas-raoul
Copy link
Member

No more crash, thanks!
The "Items" bookmarks tab does not seem to show anything even after I bookmark some items, should that be filed as a different issue? :-)

@nicolas-raoul nicolas-raoul merged commit 7d96e94 into commons-app:main Oct 16, 2025
@DeKaN
Copy link
Contributor Author

DeKaN commented Oct 17, 2025

@nicolas-raoul yes, it should be a different issue. Saving bookmarks part or UI part for displaying them may contain incorrect logic

@DeKaN DeKaN deleted the crash-fix branch October 17, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when opening bookmarked locations list

3 participants