Rename an identifier with a non-ASCII character #6460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android Studio reported that there's an identifier with a non-ASCII letter. It was nearbyFılterStateInstance, with a Turkish dotless i. I renamed to ASCII dotted i. This brings the number of Internationalization issues in Inspect Code to zero.
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Android Studio reported that there's an identifier with a non-ASCII letter. It was nearbyFılterStateInstance, with a Turkish dotless i. I renamed to ASCII dotted i.
This brings the number of Internationalization issues in Inspect Code to zero. Since I'm a bit of an internationalization nerd, I wanted this to be perfect.
Tests performed (required)
To be honest, I wasn't sure how to fully test it. The feature that uses this code appears to work only when WLM is enabled, and I don't know how to enable it. For what it's worth, the app builds and runs. This is just an identifier renaming, so I hope that this is fine.