Change hardcoded strings in the language search dialog to messages #6440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another comment: While working on this, I also noticed that "Recent Searches" is hardcoded in the XML file, and I'm not sure where does it actually appear. I fixed it, too, but perhaps it can be completely removed. Fixes commons-app#6439.
amire80
force-pushed
the
type-language-name
branch
from
da4c58b to
9bd5834
Compare
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6439.
Changed strings from hardcoded English to translatable messages.
Tests performed (required)
I ran the app in Android Studio, and it appeared identically in English.
While working on this, I also noticed that "Recent Searches" is hardcoded in the XML file, and I'm not sure where does it actually appear. I fixed it, too, but perhaps it can be completely removed.