-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: enable H/W acceleration for UploadActivity to resolve keyboard not showing on Upload Screen #6418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test it on a physical device but disabling makes sense. @pigsonthewing could you please try installing the prod debug apk generated above and see if it works for you?
Mixed results. I can see the keyboard, but it overlays either the text entry field or the "next" button; see |
|
Thanks for the review, @pigsonthewing. I'm fixing these issues 👍 |
This solves keyboard opened at the License screen issue, if we proceed by pressing next at the Upload Categories screen when the keyboard is opened
|
✅ Generated APK variants! |
|
I resolved the overlapping button issues at the Depicts and Upload Categories step screen. However, I couldn't reproduce the issue where the keyboard was overlapping the input fields at the start of the Upload. Please retest the new APK, @pigsonthewing, and let me know if you can still reproduce that issue. |
All seems to be resolved now, including the input fields at the start of the upload. Thank you. |
|
That's great :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pigsonthewing for testing. The code looks good, thanks Rohit!
Description (required)
Fixes #6412
What changes did you make and why?
UploadActivity, causing the Keyboard to not show on some devices and flickers while showing on somehardwareAccelerated=falsein theAndroidManifest.xmlfile forUploadActivityas it is enabled by default.DepictsandUploadCategoriesstep of Upload.Tests performed (required)
Tested prodDebug on Samsung A14 and Pixel 6 Emulator with API level 35 and 31 respectively.
Screenshots (for UI changes only)
Pixel 6 Emulator(API 31):
Screen_recording_20250906_181712.webm