Skip to content

Conversation

@maskaravivek
Copy link
Contributor

Description (required)

Fixes #3147

What changes did you make and why?

Tests performed (required)

have tested the artist extraction logic externally as my username and display name is the same. https://ideone.com/iCURPU

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #3232 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3232      +/-   ##
=========================================
- Coverage    6.01%   6.01%   -0.01%     
=========================================
  Files         270     270              
  Lines       11600   11605       +5     
  Branches      905     905              
=========================================
  Hits          698     698              
- Misses      10845   10850       +5     
  Partials       57      57
Impacted Files Coverage Δ
app/src/main/java/fr/free/nrw/commons/Media.java 17.9% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8472c63...8d6b532. Read the comment docs.

@neslihanturan neslihanturan changed the title With artist information fixed Fixes #3147 Upon deletion request, notification should be sent to uploader, not author Nov 29, 2019
@misaochan misaochan merged commit cbd5ee1 into commons-app:master Nov 29, 2019
@maskaravivek
Copy link
Contributor Author

Thanks for updating the PR title @neslihanturan. :)

I will try to follow this structure in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upon deletion request, notification should be sent to uploader, not author

3 participants