Skip to content

Commit e1e9d7a

Browse files
committed
fix: revert
1 parent e994e12 commit e1e9d7a

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

commitizen/providers/base_provider.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ class FileProvider(VersionProvider):
4949
def file(self) -> Path:
5050
return Path() / self.filename
5151

52-
def _get_encoding(self) -> str:
53-
return self.config.settings["encoding"]
54-
5552

5653
class JsonProvider(FileProvider):
5754
"""
@@ -61,11 +58,11 @@ class JsonProvider(FileProvider):
6158
indent: ClassVar[int] = 2
6259

6360
def get_version(self) -> str:
64-
document = json.loads(self.file.read_text(encoding=self._get_encoding()))
61+
document = json.loads(self.file.read_text())
6562
return self.get(document)
6663

6764
def set_version(self, version: str) -> None:
68-
document = json.loads(self.file.read_text(encoding=self._get_encoding()))
65+
document = json.loads(self.file.read_text())
6966
self.set(document, version)
7067
self.file.write_text(json.dumps(document, indent=self.indent) + "\n")
7168

@@ -82,11 +79,11 @@ class TomlProvider(FileProvider):
8279
"""
8380

8481
def get_version(self) -> str:
85-
document = tomlkit.parse(self.file.read_text(encoding=self._get_encoding()))
82+
document = tomlkit.parse(self.file.read_text())
8683
return self.get(document)
8784

8885
def set_version(self, version: str) -> None:
89-
document = tomlkit.parse(self.file.read_text(encoding=self._get_encoding()))
86+
document = tomlkit.parse(self.file.read_text())
9087
self.set(document, version)
9188
self.file.write_text(tomlkit.dumps(document))
9289

tests/providers/test_base_provider.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ def test_raise_for_unknown_provider(config: BaseConfig):
2929
get_provider(config)
3030

3131

32-
@pytest.mark.parametrize("encoding", ["utf-8", "latin-1"])
33-
def test_file_provider_get_encoding(config: BaseConfig, encoding: str):
34-
"""_get_encoding should return the configured encoding."""
35-
config.settings["encoding"] = encoding
36-
provider = ComposerProvider(config)
37-
assert provider._get_encoding() == encoding
38-
39-
4032
def test_json_provider_uses_encoding_with_encoding_fixture(
4133
config: BaseConfig,
4234
chdir: Path,

0 commit comments

Comments
 (0)