Skip to content

fix(cli): Respect git commit -a original behavior (#376)#471

Merged
jimthedev merged 2 commits intocommitizen:masterfrom
pawamoy:master
May 24, 2018
Merged

fix(cli): Respect git commit -a original behavior (#376)#471
jimthedev merged 2 commits intocommitizen:masterfrom
pawamoy:master

Conversation

@pawamoy
Copy link
Copy Markdown
Contributor

@pawamoy pawamoy commented Mar 5, 2018

We don't overload the -a option anymore with a plain git add ..

I have a second commit that adds tests for this fix, but unfortunately it required quite some changes and additions...

@LinusU
Copy link
Copy Markdown
Contributor

LinusU commented Mar 6, 2018

Am I missing something, or couldn't we just pass the -a flag to git when we run git commit?

@pawamoy
Copy link
Copy Markdown
Contributor Author

pawamoy commented Mar 6, 2018

If I understand correctly, any option passed to git cz is passed internally to git commit. But what was done originally when parsing a -a option was to run git add . in the repository. I simply removed that part. This PR does not implement the -a option, it removes the part that was overloading it with git add ..

See issue #376 for reference.

@jimthedev jimthedev merged commit d10c94f into commitizen:master May 24, 2018
@mysterycommand mysterycommand mentioned this pull request Jul 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawamoy @LinusU @jimthedev