Skip to content

fix(adapter): Don't print git root to stdout#428

Merged
jimthedev merged 1 commit intocommitizen:masterfrom
markhalliwell:patch-1
May 9, 2017
Merged

fix(adapter): Don't print git root to stdout#428
jimthedev merged 1 commit intocommitizen:masterfrom
markhalliwell:patch-1

Conversation

@markhalliwell
Copy link
Copy Markdown
Contributor

Whenever this is ran, it also prints out to the console. This should just be silenced since it's just being used internally.

Copy link
Copy Markdown
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jimthedev
Copy link
Copy Markdown
Member

LGTM can you ament your commit to use our the convention? I am assuming this could just be a bugfix release.

@markhalliwell
Copy link
Copy Markdown
Contributor Author

Just did a force push with the correct commit message since there was nothing to amend.

@markhalliwell markhalliwell changed the title Don't print git root to stdout fix(adapter): Don't print git root to stdout May 9, 2017
@jimthedev jimthedev merged commit d5e2424 into commitizen:master May 9, 2017
@jimthedev
Copy link
Copy Markdown
Member

Cheers!

@markhalliwell markhalliwell deleted the patch-1 branch May 9, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants