Skip to content

docs: remove the documentation now served from commit-check.com - #519

Merged
shenxianpeng merged 2 commits into
mainfrom
chore/remove-docs-moved-to-own-repo
Aug 4, 2026
Merged

docs: remove the documentation now served from commit-check.com#519
shenxianpeng merged 2 commits into
mainfrom
chore/remove-docs-moved-to-own-repo

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Aug 4, 2026

Copy link
Copy Markdown
Member

The documentation, the landing page and the blog now live together in commit-check/commit-check.com and are published from the apex domain. This removes what is left behind here.

Follows #518, which pointed the links at the new domain. That was safe to merge early; this half deliberately waited until commit-check.com was live, so there was never a window with no documentation on either host.

Removed

Path Was
docs/ The pages themselves
mkdocs.yml, netlify.toml Site and deploy-preview config
scripts/mkdocs_hooks.py Generated cli.md, wrote legacy redirect stubs
docs job in main.yml Built the site and published to docs.commit-check.com
docs extra, docs/docs-live nox sessions Build dependencies
6 tests in rules_catalog_test.py Compared the catalog against docs/

The anti-drift tests did not disappear

They moved to tests/docs_sync_test.py in the documentation repository, next to the pages they read. Its CI installs this package and runs them, so a rule or option still cannot change here without failing there. The guard was verified by injecting a wrong default and confirming it fails.

The RULES_DOCS_URL assertion added in #518 stays in this repository, since the constant lives here.

Two things stayed behind

They belong to the README, not to the documentation:

  • assets/demo.gif — the README embeds it by raw URL into docs/demo.gif. Deleting it would have broken the demo image in the README and on the PyPI page. Moved rather than removed.
  • assets/demo.tape — the VHS script that regenerates it.

While checking that, two more README links turned out to point at docs/configuration.rst, which has not existed since the move off Sphinx — already broken before this change, now pointing at commit-check.com/configuration/.

Verification

$ pytest tests/ -q
455 passed, 1 failed

The failure is test_load_config_file_permission_error, which uses os.chmod(0o000) and cannot fail as root; it reproduces on main and is unrelated.

No references to docs.commit-check.com remain anywhere in the repository.

Note on #517

#517 is still open and now conflicts with main. Its content — the rewritten example.md and what-is-new.md — is already in commit-check.com, since the migration was taken from that branch. It wants closing as superseded rather than merging.

The documentation, the landing page and the blog now live together in
commit-check/commit-check.com and are published from the apex domain, so
everything that built and deployed a site from this repository is gone:
docs/, mkdocs.yml, netlify.toml, the build hooks, the docs CI job and the
docs extra.

The six tests that compared the rules catalog against the documentation
move with the pages they read; commit-check.com installs this package in
CI and runs them there, so a rule or option still cannot change here
without failing there.

Two things stay behind because they belong to the README rather than to
the documentation: the demo recording, moved to assets/, and its VHS
script. The README's link to it was pointing into docs/ and would have
broken. Two more README links pointed at docs/configuration.rst, which
had not existed since the move off Sphinx.
@shenxianpeng
shenxianpeng requested a review from a team as a code owner August 4, 2026 05:47
@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for commit-check failed. Why did it fail? →

Name Link
🔨 Latest commit 1633052
🔍 Latest deploy log https://app.netlify.com/projects/commit-check/deploys/6a717d1e67b4a600087c4c4a

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@pre-commit-ci[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ef6d9fb-5a41-4200-954a-d0814343e3cd

📥 Commits

Reviewing files that changed from the base of the PR and between c28097b and 1633052.

⛔ Files ignored due to path filters (3)
  • assets/demo.gif is excluded by !**/*.gif
  • docs/assets/favicon.svg is excluded by !**/*.svg
  • docs/assets/logo.svg is excluded by !**/*.svg
📒 Files selected for processing (29)
  • .github/copilot-instructions.md
  • .github/workflows/main.yml
  • .gitignore
  • .pre-commit-config.yaml
  • README.md
  • assets/demo.tape
  • docs/assets/extra.css
  • docs/changelog.md
  • docs/configuration.md
  • docs/example.md
  • docs/getting-started/installation.md
  • docs/getting-started/quickstart.md
  • docs/getting-started/why.md
  • docs/guides/ai-attribution.md
  • docs/guides/github-actions.md
  • docs/guides/organization.md
  • docs/guides/pre-commit.md
  • docs/guides/signoff.md
  • docs/index.md
  • docs/migration.md
  • docs/rules.md
  • docs/troubleshoot.md
  • docs/what-is-new.md
  • mkdocs.yml
  • netlify.toml
  • noxfile.py
  • pyproject.toml
  • scripts/mkdocs_hooks.py
  • tests/rules_catalog_test.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added chore documentation Improvements or additions to documentation tests Add test related changes labels Aug 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (c28097b) to head (1633052).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   97.34%   97.43%   +0.08%     
==========================================
  Files          12       12              
  Lines        1207     1207              
==========================================
+ Hits         1175     1176       +1     
+ Misses         32       31       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shenxianpeng shenxianpeng removed tests Add test related changes chore labels Aug 4, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 4, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 84.77%

⚡ 1 improved benchmark
✅ 403 untouched benchmarks
⏩ 116 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
test_empty_message_passes 4.3 ms 2.3 ms +84.77%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/remove-docs-moved-to-own-repo (ec2c423) with main (c28097b)

Open in CodSpeed

Footnotes

  1. 116 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@shenxianpeng
shenxianpeng merged commit 631ae91 into main Aug 4, 2026
28 of 32 checks passed
@shenxianpeng
shenxianpeng deleted the chore/remove-docs-moved-to-own-repo branch August 4, 2026 06:11
@shenxianpeng shenxianpeng changed the title chore: remove the documentation now served from commit-check.com docs: remove the documentation now served from commit-check.com Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant