Skip to content

feat: Update pre-commit configuration and enhance test coverage #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 2 commits into from
Jan 31, 2026
Merged

feat: Update pre-commit configuration and enhance test coverage #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f8207
feat: Update pre-commit configuration and enhance test coverage
shenxianpeng Jan 31, 2026
b6c26ce
refactor: remove duplicate test classes and fix import style issues (…
Copilot Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repos:
- id: trailing-whitespace
- id: name-tests-test
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.14.10
rev: v0.14.14
hooks:
- id: ruff-check
args: [ --fix ]
Expand All @@ -31,7 +31,7 @@ repos:
hooks:
- id: codespell
- repo: https://github.com/commit-check/commit-check
rev: v2.2.1
rev: v2.2.2
hooks:
- id: check-message
stages: [commit-msg]
Expand Down
2 changes: 1 addition & 1 deletion cchk.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ ignore_authors = ["dependabot[bot]", "copilot[bot]", "pre-commit-ci[bot]"]
[branch]
# https://conventional-branch.github.io/
conventional_branch = true
allow_branch_types = ["feature", "bugfix", "hotfix", "release", "chore", "feat", "fix"]
allow_branch_types = ["feature", "bugfix", "hotfix", "release", "chore", "feat", "fix", "copilot"]
require_rebase_target = "main"
ignore_authors = ["dependabot[bot]", "copilot[bot]", "pre-commit-ci[bot]", "shenxianpeng"]
4 changes: 2 additions & 2 deletions commit_check/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
_toml = None # type: ignore[assignment]


def _find_check(checks: list, check_type: str) -> dict | None:
def _find_check(checks: list, check_type: str) -> Optional[dict]:
"""Return the first check dict matching check_type, else None."""
for check in checks:
if check.get("check") == check_type:
Expand Down Expand Up @@ -254,7 +254,7 @@ def print_error_message(check_type: str, regex: str, error: str, reason: str):
print(error)


def print_suggestion(suggest: str | None) -> None:
def print_suggestion(suggest: Optional[str]) -> None:
"""Print suggestion to user
:param suggest: what message to print out
"""
Expand Down
80 changes: 0 additions & 80 deletions tests/config_edge_test.py
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions tests/config_fallback_test.py
View file
Open in desktop

This file was deleted.

94 changes: 0 additions & 94 deletions tests/config_import_test.py
View file
Open in desktop

This file was deleted.

Loading
Loading