tests/config_test.py (2)

224-228: Use specific exception type instead of bare Exception.

The static analysis tool correctly flags this as B017. Catching bare Exception makes the test fragile—it will pass even if an unexpected error occurs. Use the specific TOML parsing exception.

💡 Suggested fix

             try:
-                with pytest.raises(Exception):  # Should raise a TOML parsing error
+                # tomllib raises TOMLDecodeError, tomli raises TOMLDecodeError
+                # Both inherit from ValueError
+                with pytest.raises((ValueError,)):  # TOML parsing error
                     load_config(f.name)
             finally:
                 os.unlink(f.name)

---

253-282: Duplicate test method name test_tomli_import_fallback.

This test method (lines 253-282) has the same name as another test method in TestConfig class (lines 140-207). While they're in different classes so there's no actual conflict, having identically named tests can cause confusion when reviewing test results.

tests/engine_test.py (4)

156-159: Remove duplicate assertions.

Lines 157-159 contain duplicate assertions that appear to be copy-paste artifacts. Each assertion is identical to line 157.

💡 Suggested fix

         result = validator.validate(context)
         assert result == ValidationResult.PASS
-        assert result == ValidationResult.PASS
-        assert result == ValidationResult.PASS

---

304-312: Remove duplicate assertions.

Lines 308-312 duplicate the assertions from lines 304-307. This appears to be a copy-paste error.

💡 Suggested fix

         # Called once for skip logic ("an"), once for value ("ae")
         assert mock_get_commit_info.call_count == 2
         assert mock_get_commit_info.call_args_list[0][0][0] == "an"
         assert mock_get_commit_info.call_args_list[1][0][0] == "ae"
-        assert result == ValidationResult.PASS
-        # Called once for skip logic ("an"), once for value ("ae")
-        assert mock_get_commit_info.call_count == 2
-        assert mock_get_commit_info.call_args_list[0][0][0] == "an"
-        assert mock_get_commit_info.call_args_list[1][0][0] == "ae"

---

986-1007: Unused mock parameter mock_get_commit_info.

The static analysis tool correctly identifies that mock_get_commit_info is declared but never used in this test. Either use it or remove it from the decorator stack.

💡 Suggested fix

-    `@patch`("commit_check.engine.get_commit_info")
     `@patch`("commit_check.engine.has_commits")
     `@pytest.mark.benchmark`
     def test_commit_message_validator_failure(
-        self, mock_has_commits, mock_get_commit_info
+        self, mock_has_commits
     ):

---

930-933: Prefer comparing enum members directly instead of to integers.

While comparing ValidationResult.PASS == 0 works due to Python's enum behavior, it's more explicit and maintainable to compare enum members directly.

💡 Suggested improvement

     def test_validation_result_values(self):
         """Test ValidationResult enum values."""
-        assert ValidationResult.PASS == 0
-        assert ValidationResult.FAIL == 1
+        assert ValidationResult.PASS.value == 0
+        assert ValidationResult.FAIL.value == 1

Note: The existing TestValidationResult class (lines 26-31) already does this correctly with .value.

tests/engine_test.py (1)

813-840: LGTM! Consider verifying no unexpected keys exist.

The test correctly validates all expected VALIDATOR_MAP entries. For completeness, you could also assert that the map doesn't contain unexpected keys:

💡 Optional enhancement

         for check, validator_class in expected_mappings.items():
             assert engine.VALIDATOR_MAP[check] == validator_class
+
+        # Verify no unexpected keys in VALIDATOR_MAP
+        assert set(engine.VALIDATOR_MAP.keys()) == set(expected_mappings.keys())

,

tests/config_test.py (1)

368-383: Consider avoiding exec() for import testing.

While exec() works for testing import behavior, it's flagged by security linters (S102) and makes debugging harder. Consider using importlib for a more maintainable approach.

💡 Alternative approach

`@pytest.mark.benchmark`
def test_tomli_import_fallback_simulation(self):
    """Test tomli import fallback by simulating the ImportError condition."""
    import importlib
    import importlib.util
    
    # Test case 1: Verify tomllib is used on Python 3.11+
    if sys.version_info >= (3, 11):
        spec = importlib.util.find_spec("tomllib")
        assert spec is not None, "tomllib should be available"
    
    # Test case 2: Verify the config module loads successfully
    from commit_check.config import toml_load
    assert callable(toml_load)