Skip to content

fix: update default values to algin with configuration file #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 2 commits into from
Oct 20, 2025
Merged

fix: update default values to algin with configuration file #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0c199
chore: align default values with config
shenxianpeng Oct 20, 2025
53e0f12
chore: fix by pre-commit
shenxianpeng Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions commit_check/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@

# Handle different default values for different rules
DEFAULT_BOOLEAN_RULES = {
"subject_capitalized": True,
"subject_imperative": True,
"subject_capitalized": False,
"subject_imperative": False,
"allow_merge_commits": True,
"allow_revert_commits": True,
"allow_empty_commits": True,
Expand Down
2 changes: 1 addition & 1 deletion commit_check/imperatives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"adjust",
"aggregate",
"allow",
"append",
"alignappend",
"apply",
"archive",
"assert",
Expand Down
4 changes: 2 additions & 2 deletions docs/configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ Example Configuration
[commit]
# https://www.conventionalcommits.org
conventional_commits = true
subject_capitalized = true
subject_imperative = true
subject_capitalized = false
subject_imperative = false
# subject_max_length = 50 # Optional - no limit by default
# subject_min_length = 5 # Optional - no limit by default
allow_commit_types = ["feat", "fix", "docs", "style", "refactor", "test", "chore"]
Expand Down
Loading