Skip to content

fix: update regex to support breaking changes #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 1 commit into from
Oct 12, 2025
Merged

fix: update regex to support breaking changes #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion commit_check/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ def _validate_subject(self, subject: str) -> ValidationResult:
# Extract first word (ignore conventional commit prefixes)
import re

match = re.match(r"^(?:\w+(?:\([^)]*\))?[!:]?\s*)?(\w+)", subject)
# support breaking changes (feat!:)
match = re.match(r"^(?:\w+(?:\([^)]*\))?!?:\s*)?(\w+)", subject)
if not match:
return ValidationResult.PASS

Expand Down
20 changes: 20 additions & 0 deletions tests/engine_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,3 +778,23 @@ def test_validate_short_subject(self):
# "add" is a valid imperative word with conventional prefix
result = validator.validate(context)
assert result == ValidationResult.PASS

def test_validate_with_breaking_change(self):
"""Test validation with breaking change notation."""
rule = ValidationRule(check="imperative")
validator = SubjectImperativeValidator(rule)
context = ValidationContext(stdin_text="feat!: update authentication system")

# "update" is a valid imperative word with breaking change notation
result = validator.validate(context)
assert result == ValidationResult.PASS

def test_validate_with_scoped_breaking_change(self):
"""Test validation with scoped breaking change notation."""
rule = ValidationRule(check="imperative")
validator = SubjectImperativeValidator(rule)
context = ValidationContext(stdin_text="fix(auth)!: resolve login bug")

# "resolve" is a valid imperative word with scope and breaking change notation
result = validator.validate(context)
assert result == ValidationResult.PASS
Loading